Fix ldap integration tests #5122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UserManager Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
|
@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @MorrisJobke to be potential reviewers. |
Member
Author
|
@rullzer maye maybe? 😉 |
MorrisJobke
approved these changes
Jun 9, 2017
LukasReschke
approved these changes
Jun 9, 2017
blizzz
added a commit
that referenced
this pull request
Jun 9, 2017
add missing INotificationManager when creating User backend, LDAP UserManager Signed-off-by: Arthur Schiwon <[email protected]> Make IDE happy Signed-off-by: Arthur Schiwon <[email protected]> add convenience script to run all tests at once Signed-off-by: Arthur Schiwon <[email protected]>
Member
Author
|
Thx guys! Backport to 12 in #5320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some adjustments weren't done completely on the way it seems. Needs a backport to stable12. They run now succeed locally (and since in docker should run anyplace).
Important is the first commit, no. 2 is cosmetics, no. a convenience addition
@nextcloud/ldap